Skip to content

fix(localizations): Adjust account deletion text for en-GB and fi-FI#6814

Merged
jacekradko merged 4 commits intoclerk:mainfrom
severi:main
Sep 19, 2025
Merged

fix(localizations): Adjust account deletion text for en-GB and fi-FI#6814
jacekradko merged 4 commits intoclerk:mainfrom
severi:main

Conversation

@severi
Copy link
Copy Markdown
Contributor

@severi severi commented Sep 19, 2025 •
edited by coderabbitai bot
Loading

Account deletion did not work according to instructions if en-GB locale was chosen, fixed with this PR

Also added translations for Finnish

Summary by CodeRabbit

  • New Features

    • None.

  • Bug Fixes

    • Updated en-GB account deletion confirmation placeholder to “Delete account” for clarity.
    • Corrected fi-FI translations: placeholder now “Poista tili” and instruction text aligned to “Kirjoita ‘Poista tili’ poistaaksesi tilisi.”

  • Chores

    • Released a patch update to the localizations package reflecting these text corrections.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 19, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 8c2889c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 19, 2025

@severi is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 19, 2025 •
edited
Loading

Walkthrough

Patch-level update introduces localization string adjustments for account deletion text in en-GB and fi-FI. A changeset entry bumps @clerk/localizations. No keys added or removed; only string values changed.

Changes

Cohort / File(s) Summary
Localization updates
packages/localizations/src/en-GB.ts, packages/localizations/src/fi-FI.ts		 Updated confirm deletion placeholder in en-GB. In fi-FI, updated confirm deletion placeholder and delete page action description to Finnish phrasing. No key or structural changes.
Changeset
.changeset/orange-rocks-sell.md		 Adds patch release note for @clerk/localizations describing the updated deletion placeholder/action description for en-GB and fi-FI.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at strings so neat,
New words hop in on nimble feet.
en‑GB, fi‑FI, tidy and bright—
“Delete account” now reads just right.
With a patchy hop, I sign and cheer,
Localization spring is here! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix(localizations): Adjust account deletion text for en-GB and fi-FI" succinctly and accurately describes the primary change, which is updating localization strings related to account deletion. It specifies the affected area ("localizations") and the exact locales changed (en-GB and fi-FI), making the scope clear to reviewers. The phrasing is concise, follows conventional commit style, and avoids vague or noisy language.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 99922ec and 0e5a43e.

📒 Files selected for processing (3)
  • .changeset/orange-rocks-sell.md (1 hunks)
  • packages/localizations/src/en-GB.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (2 hunks)
🧰 Additional context used
📓 Path-based instructions (8)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/orange-rocks-sell.md
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels

Files:

  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/en-GB.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/en-GB.ts
packages/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/en-GB.ts
packages/**/*.{ts,tsx,d.ts}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Packages should export TypeScript types alongside runtime code

Files:

  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/en-GB.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Prefer readonly for properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Use const assertions for literal types: as const
Use satisfies operator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports: import type { ... } from ...
No any types without justification
Proper error handling with typed errors
Consistent use of readonly for immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)

Files:

  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/en-GB.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Localization files must be placed in 'packages/localizations/'.

Files:

  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/en-GB.ts
**/*.{js,ts,tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.

Files:

  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/en-GB.ts
🔇 Additional comments (4)
.changeset/orange-rocks-sell.md (1)

1-5: Changeset looks correct; patch bump for @clerk/localizations.

Scope and description align with the actual locale string fixes.

packages/localizations/src/fi-FI.ts (2)

210-210: Correct Finnish placeholder.

'Poista tili' is appropriate and matches the confirmation phrase.

1033-1033: Action description correctly localized to match the placeholder.

Instructs to type "Poista tili", consistent with the placeholder and confirm CTA.

packages/localizations/src/en-GB.ts (1)

209-209: Placeholder doesn't match actionDescription — update required.
packages/localizations/src/en-GB.ts (line 209): placeholder = 'Delete account' but actionDescription = 'Type "Delete account" below to continue.' Align the strings.

Likely an incorrect or invalid review comment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsoriano wobsoriano changed the title Fix delete account placeholder to match action description for en-GB, translate delete account action description+placeholder for fi-FI fix(localizations): Adjust account deletion text for en-GB and fi-FI Sep 19, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Sep 19, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6814

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6814

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6814

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6814

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6814

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6814

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6814

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6814

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6814

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6814

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6814

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6814

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6814

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6814

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6814

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6814

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6814

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6814

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6814

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6814

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6814

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6814

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6814

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6814

commit: 0e5a43e

@jacekradko jacekradko merged commit 4a142e9 into clerk:main Sep 19, 2025
3 of 4 checks passed
@clerk-cookie clerk-cookie mentioned this pull request Sep 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsoriano wobsoriano wobsoriano approved these changes

Assignees

No one assigned

Labels

localizations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@severi @wobsoriano @jacekradko @clerk-cookie @alexcarpenter